[Extend Dallas 1-Wire] Add support for read PIO-A of DS2406 #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmcbc
changed the title
mcspr
reviewed
Mar 9, 2020
code/espurna/sensors/DallasSensor.h
Outdated
| for (unsigned char i = 0; i < DS_DATA_SIZE; i++) { | ||
| data[i] = _wire->read(); | ||
| } | ||
| _wire->reset(); |
There was a problem hiding this comment.
I have noticed that the other sections does check for the 'expected' return value. Should it do the same here, and the one reset() below?
https://github.com/PaulStoffregen/OneWire/blob/master/OneWire.cpp#L164
// Returns 1 if a device asserted a presence pulse, 0 otherwise.
Based on the commit history, hot-plugging is the reason for that branch:
90c5155
There was a problem hiding this comment.
@mcspr you were right, sorry for that.
Fixed, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Dallas 1-Wire
Extend the devices supported with DALLAS 1-WIRE.
The DS2406 can be read, the system adds it as a digital device and only read PIO-A state.
Electronics
Just a Note: if it's to receive a signal from a relay I put a 10K resistor to 3.3v as a pull up or to GND as a pull down depending if relay NC is GND or 3.3v and NO is a open signal)
Devices
To have access to DALLAS devices I use in platformio:
default_envs = itead-sonoff-basic-r2-dallasYou can mix DS18x20 devices with this new DS2406.
Because only have 5 units of DS2406, I test all in the same Sonoff, it detects all and work without any problem.